Conversation
bufdev
approved these changes
Oct 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #600 and fixes #605
This revisits the
buf generatecommand so that we consolidate all of our generation logic inappprotoandappprotoos. With this,buf protoc,buf generate, and our server-side remote generation all use the same code paths.This also fixes how we handle insertion points so that our behavior is aligned with
protoc: we only permit insertion points to act upon other plugins configured to the same_outdirectory. For example,The
insertion-point-writerwill only have access to the files deposited ingen/proto/insertion, which is correctly configured above. Note that this was not previously the case.Aside from the unit tests included here, this was tested against a variety of different cases, including combinations of
remoteandlocalplugins (including insertion points on either side).